Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jun 21, 2022

In case there are conflicting changes to breeze command in several
PRs, you might get conflicting images printed. in such case you
should run breeze regenerate-command-images


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

In case there are conflicting changes to breeze command in several
PRs, you might get conflicting images printed. in such case you
should run `breeze regenerate-command-images`
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jun 21, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk mentioned this pull request Jun 21, 2022
@potiuk potiuk merged commit 864cbc9 into apache:main Jun 21, 2022
@potiuk potiuk deleted the add-beter-instruction-on-conflicting-images branch June 21, 2022 13:59
potiuk added a commit to potiuk/airflow that referenced this pull request Jun 29, 2022
…ed (apache#24581)

In case there are conflicting changes to breeze command in several
PRs, you might get conflicting images printed. in such case you
should run `breeze regenerate-command-images`

(cherry picked from commit 864cbc9)
@ephraimbuddy ephraimbuddy added this to the Airflow 2.3.3 milestone Jun 30, 2022
@ephraimbuddy ephraimbuddy added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants