Fix the xfail test for batch #23918
Closed
Fix the xfail test for batch #23918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
vincbeck
commented
May 25, 2022
| # moto transitions the Batch job status automatically. | ||
|
|
||
| job_name = "test-job" | ||
| job_cmd = ['/bin/sh -c "for a in `seq 1 2`; do echo Hello World; sleep 0.25; done"'] |
Contributor
Author
There was a problem hiding this comment.
I removed this optional parameter for multiple reasons:
- It does not add any value to the test
- For some reasons, the command failed to run when I run pytest
vincbeck
commented
May 25, 2022
| job_description = aws_clients.batch.describe_jobs(jobs=[job_id]) | ||
| job_status = [job for job in job_description["jobs"] if job["jobId"] == job_id][0]["status"] | ||
| assert job_status == "PENDING" | ||
| assert job_status == "RUNNABLE" |
Contributor
Author
There was a problem hiding this comment.
It turns out the initial status returned by moto is RUNNABLE
Contributor
Author
|
For the record, the test is still failing. I need to investigate |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the test in the batch hook was marked as xfail as part of this PR. #23539 has been created to fix all the tests flagged as xfail in airflow. This PR fixes the only test related to AWS as part of this issue