The output of commands of Breeze are only generated when they change #23570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 8, 2022
potiuk
force-pushed
the
only-generate-images-when-any-command-changes
branch
2 times, most recently
from
52ddecd to
bd369f2
Compare
Member
Author
|
Also - as a side effect - we have much nicer and cleaner SVG output of the breeze commands with Rich 12.4.0:
|
potiuk
force-pushed
the
only-generate-images-when-any-command-changes
branch
from
bd369f2 to
bae707c
Compare
potiuk
force-pushed
the
only-generate-images-when-any-command-changes
branch
3 times, most recently
from
d9b96cc to
f0f6d7a
Compare
potiuk
force-pushed
the
only-generate-images-when-any-command-changes
branch
from
f0f6d7a to
42a97f0
Compare
eladkal
approved these changes
May 9, 2022
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Previously we generated output of all the commands from Breeze always, hoping that they will be the same, but rich already had two changes in the format of the SVG files which made the output different and breaking our PRs. Temporarily we pinned rich to fix the output, but better solution is to get the hash of all the configuration options and see if it changed, and only run generation when it did. This way we keep automated generation on pre-commit but we are protected from accidental change of the output. We also remove the rich limits and regenerated all svg files to ones generated by 12.4.0. Also found a way to run the check if we should run generation at all in pre-commit without prior installing breeze. Fixes: apache#22908
potiuk
force-pushed
the
only-generate-images-when-any-command-changes
branch
from
42a97f0 to
80d6e41
Compare
Member
Author
|
Jsut random test refused to start. |
Member
Author
|
Merging. |
potiuk
added a commit
that referenced
this pull request
May 12, 2022
…23570) Previously we generated output of all the commands from Breeze always, hoping that they will be the same, but rich already had two changes in the format of the SVG files which made the output different and breaking our PRs. Temporarily we pinned rich to fix the output, but better solution is to get the hash of all the configuration options and see if it changed, and only run generation when it did. This way we keep automated generation on pre-commit but we are protected from accidental change of the output. We also remove the rich limits and regenerated all svg files to ones generated by 12.4.0. Also found a way to run the check if we should run generation at all in pre-commit without prior installing breeze. Fixes: #22908 (cherry picked from commit 7c7b001)
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
May 21, 2022
…23570) Previously we generated output of all the commands from Breeze always, hoping that they will be the same, but rich already had two changes in the format of the SVG files which made the output different and breaking our PRs. Temporarily we pinned rich to fix the output, but better solution is to get the hash of all the configuration options and see if it changed, and only run generation when it did. This way we keep automated generation on pre-commit but we are protected from accidental change of the output. We also remove the rich limits and regenerated all svg files to ones generated by 12.4.0. Also found a way to run the check if we should run generation at all in pre-commit without prior installing breeze. Fixes: #22908 (cherry picked from commit 7c7b001)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we generated output of all the commands from Breeze always,
hoping that they will be the same, but rich already had two changes
in the format of the SVG files which made the output different and
breaking our PRs.
Temporarily we pinned rich to fix the output, but better solution is
to get the hash of all the configuration options and see if it changed,
and only run generation when it did. This way we keep automated
generation on pre-commit but we are protected from accidental change
of the output.
We also remove the rich limitations.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.