Add IPV6 form of the address in cassandra status check #23537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes problem introduced in 3.0.26 of cassandra image which adds square brackets around IP address regardless of its type. The problem was workarounded by pinning cassandra to 3.0.25 in the #apache#23522 as a quick fix, but this one introducec permanent, future-proof solution. Based on discussion in https://issues.apache.org/jira/browse/CASSANDRA-17612 Fixes: apache#23523
Member
Author
Member
Author
|
Seems it works @eladkal :). |
eladkal
approved these changes
May 7, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
potiuk
added a commit
that referenced
this pull request
May 7, 2022
This PR fixes problem introduced in 3.0.26 of cassandra image which adds square brackets around IP address regardless of its type. The problem was workarounded by pinning cassandra to 3.0.25 in the ##23522 as a quick fix, but this one introducec permanent, future-proof solution. Based on discussion in https://issues.apache.org/jira/browse/CASSANDRA-17612 Fixes: #23523 (cherry picked from commit 22a5642)
ephraimbuddy
pushed a commit
that referenced
this pull request
May 8, 2022
This PR fixes problem introduced in 3.0.26 of cassandra image which adds square brackets around IP address regardless of its type. The problem was workarounded by pinning cassandra to 3.0.25 in the ##23522 as a quick fix, but this one introducec permanent, future-proof solution. Based on discussion in https://issues.apache.org/jira/browse/CASSANDRA-17612 Fixes: #23523 (cherry picked from commit 22a5642)
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
pushed a commit
that referenced
this pull request
May 21, 2022
This PR fixes problem introduced in 3.0.26 of cassandra image which adds square brackets around IP address regardless of its type. The problem was workarounded by pinning cassandra to 3.0.25 in the ##23522 as a quick fix, but this one introducec permanent, future-proof solution. Based on discussion in https://issues.apache.org/jira/browse/CASSANDRA-17612 Fixes: #23523 (cherry picked from commit 22a5642)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes problem introduced in 3.0.26 of cassandra image which
adds square brackets around IP address regardless of its type.
The problem was workarounded by pinning cassandra to 3.0.25 in
the ##23522 as a quick fix, but this one introducec permanent,
future-proof solution.
Based on discussion in https://issues.apache.org/jira/browse/CASSANDRA-17612
Fixes: #23523
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.