Tests for provider code structure #23351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 28, 2022 17:51
Change-Id: Ie1c4064ad99b40ef641089a1a9f3f358b758d7ca
Change-Id: I41fb01a969202bdef50f6c178569f1547062da21
o-nikolas
reviewed
Apr 29, 2022
ferruzzi
reviewed
May 2, 2022
Change-Id: I24b78bc91c1df61458091900c8d21f7dd0d727a8
bhirsz
force-pushed
the
test_for_missing_assets
branch
from
e2d9ebb to
98c88eb
Compare
o-nikolas
approved these changes
May 6, 2022
potiuk
approved these changes
May 8, 2022
potiuk
reviewed
May 8, 2022
| 'ads_to_gcs', | ||
| } | ||
| def print_sorted(container: Set, indent: str = " ") -> None: | ||
| sorted_container = sorted(container) |
Member
There was a problem hiding this comment.
Indeed. Sorting is important for predictability!
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had test class in test_project_structure.py that checked coverage of system tests/examples (and other misc stuff in provider code structure). Unfortunately there were some bugs (not all operators were found, some tests always passed, the test class worked only for Google).
I have refactored the tests in the test_project_structure.py so it could be reused by other providers. For Google we're now using two test class bases:
See the docker and elasticsearch providers test class (that uses ExampleCoverageTest base) to see how those test bases can be used or optionally extended with custom behaviour.