Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Mar 29, 2022

We checked that the changes introduced between 3.4.4 and 3.4.5
do not require from us to change the vendored-in security manager.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk
Copy link
Member Author

potiuk commented Mar 29, 2022

aaaah

@potiuk
Copy link
Member Author

potiuk commented Mar 29, 2022

Bug in new breeze 😱 after merge

@potiuk potiuk force-pushed the update-fab-to-latest-in-3-4-line branch from 458505d to 630b1ac Compare March 29, 2022 18:04
@potiuk
Copy link
Member Author

potiuk commented Mar 29, 2022

Rebased after fix in #22597 (bad rebase for Breee2 change)

We checked that the changes introduced between 3.4.4 and 3.4.5
do not require from us to change the vendored-in security manager.
@potiuk potiuk force-pushed the update-fab-to-latest-in-3-4-line branch from 630b1ac to ada035b Compare March 29, 2022 19:20
@potiuk
Copy link
Member Author

potiuk commented Mar 29, 2022

Just checking - seems the failure was due to bad merge already fixed in #22592 but better to be safe than sorry

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 29, 2022
@potiuk potiuk merged commit d4846e4 into apache:main Mar 29, 2022
@potiuk potiuk deleted the update-fab-to-latest-in-3-4-line branch March 29, 2022 20:15
@ephraimbuddy ephraimbuddy added this to the Airflow 2.2.5 milestone Mar 29, 2022
ephraimbuddy pushed a commit that referenced this pull request Mar 29, 2022
We checked that the changes introduced between 3.4.4 and 3.4.5
do not require from us to change the vendored-in security manager.

(cherry picked from commit d4846e4)
ephraimbuddy pushed a commit that referenced this pull request Mar 30, 2022
We checked that the changes introduced between 3.4.4 and 3.4.5
do not require from us to change the vendored-in security manager.

(cherry picked from commit d4846e4)
@ephraimbuddy ephraimbuddy added the type:misc/internal Changelog: Misc changes that should appear in change log label Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge type:misc/internal Changelog: Misc changes that should appear in change log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants