Add links for BigQuery Data Transfer #22280
Conversation
boring-cyborg
bot
added
area:providers
provider:google
There was a problem hiding this comment.
These args don't seem to be optional. Looks like they will always be provided when BigQueryDataTransferConfigLink.persist() is called but I could be missing something along the way here. I suspect the link value wouldn't be correct if these were missing too?
| region: Optional[str], | |
| config_id: Optional[str], | |
| project_id: Optional[str], | |
| region: str, | |
| config_id: str, | |
| project_id: str, |
There was a problem hiding this comment.
Could the type annotation be added here as well?
There was a problem hiding this comment.
Is this possibly a breaking change in behavior?
There was a problem hiding this comment.
Actually, without this it did not work correctly. Before only checking is state in expected (succeed), but what if this already failed? As I understand and implement sensors is: if succeed then return True, if waiting - False, if failed - raise. Otherwise we are waiting for the result which has already failed - what is the reason in this situation?
The problem I noticed is that the sensor was waiting in loop for the already failed result - what I think is not something expected
|
We probably need to update #9941 accordingly |
|
Need to resolve conflicts first too. |
Updated :) |
5 participants
Add links to assets for BigQuery Data Transfer
Co-authored-by: Wojciech Januszek [email protected]
Co-authored-by: Lukasz Wyszomirski [email protected]
Co-authored-by: Maksim Yermakou [email protected]
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.