Skip to content

Conversation

@shuhoy
Copy link
Contributor

@shuhoy shuhoy commented Mar 14, 2022

Point to change

For simplicity and due to issue #22034 , change to use function run_extract in BigQueryHook to transfer execution.

Related issue

closes #22034


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@shuhoy shuhoy requested a review from turbaszek as a code owner March 14, 2022 15:55
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Mar 14, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 14, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk changed the title Bugfix/#22034 Refactor BigQuery to GCS Operator Mar 15, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 15, 2022
@potiuk
Copy link
Member

potiuk commented Mar 15, 2022

Static checks failing I am afraid

@shuhoy
Copy link
Contributor Author

shuhoy commented Mar 16, 2022

I'm also afraid about static check results.
I have an idea of the cause and will check it, please wait.

@shuhoy
Copy link
Contributor Author

shuhoy commented Mar 17, 2022

All checks passed!!:rocket:

@eladkal
Copy link
Contributor

eladkal commented Mar 17, 2022

i think you had unsuccessful rebase

@shuhoy
Copy link
Contributor Author

shuhoy commented Mar 17, 2022

@eladkal
I'm very sorry, I will find a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQueryToGCSOperator: Invalid dataset ID error

6 participants