Skip to content

Conversation

@KevinYanesG
Copy link
Contributor

related: #21457

Following @potiuk and @ashb comments I just quickly corrected the PostgresHook imports of the pipeline tutorial.

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 10, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk merged commit a2abf66 into apache:main Feb 10, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Feb 10, 2022

Awesome work, congrats on your first merged pull request!

@potiuk potiuk added the type:doc-only Changelog: Doc Only label Feb 10, 2022
@potiuk potiuk added this to the Airflow 2.2.4 milestone Feb 10, 2022
potiuk pushed a commit that referenced this pull request Feb 10, 2022
@potiuk
Copy link
Member

potiuk commented Feb 10, 2022

Merged and cherry-picked to 2.2.4. Thanks @KevinYanesG !

@jedcunningham jedcunningham added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) and removed type:doc-only Changelog: Doc Only labels Feb 10, 2022
jedcunningham pushed a commit that referenced this pull request Feb 10, 2022
ferruzzi pushed a commit to ferruzzi/airflow that referenced this pull request Feb 11, 2022
@KevinYanesG KevinYanesG deleted the fix-postgresHook-import-pipeline-tutorial branch February 15, 2022 14:20
jedcunningham pushed a commit that referenced this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants