Fix broken tests after URL restructure PR #21489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
commented
Feb 10, 2022
| view = conf.get('webserver', 'dag_default_view').lower() | ||
| url = flask.url_for(f"Airflow.{view}") | ||
| return f"{url}?{parse.urlencode(query)}" | ||
| return flask.url_for(f"Airflow.{view}", **query) |
Member
Author
There was a problem hiding this comment.
Turns out url_for handles url prams and everything else gets set as query params, so the fix was easy :)
eladkal
approved these changes
Feb 10, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
Member
|
also cc @IKholopov |
uranusjr
approved these changes
Feb 10, 2022
potiuk
approved these changes
Feb 10, 2022
ferruzzi
pushed a commit
to ferruzzi/airflow
that referenced
this pull request
Feb 11, 2022
jedcunningham
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20730 somehow broken tests, not sure how that PR was green