Fix Resources __eq__ check #21442
Merged
Fix Resources __eq__ check #21442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingzh
force-pushed
the
pz-fix-resources-eq
branch
from
a701af6 to
6e46fe0
Compare
KevinYang21
approved these changes
Feb 8, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
pingzh
force-pushed
the
pz-fix-resources-eq
branch
from
6e46fe0 to
181db0a
Compare
2 tasks
pingzh
force-pushed
the
pz-fix-resources-eq
branch
5 times, most recently
from
704519f to
57d0960
Compare
uranusjr
reviewed
Feb 10, 2022
pingzh
force-pushed
the
pz-fix-resources-eq
branch
from
57d0960 to
83c78b0
Compare
uranusjr
reviewed
Feb 10, 2022
uranusjr
approved these changes
Feb 10, 2022
potiuk
approved these changes
Feb 10, 2022
ferruzzi
pushed a commit
to ferruzzi/airflow
that referenced
this pull request
Feb 11, 2022
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 16, 2022
(cherry picked from commit 6b30844)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 20, 2022
(cherry picked from commit 6b30844)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit 6b30844)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit 6b30844)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit 6b30844)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 22, 2022
(cherry picked from commit 6b30844)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 24, 2022
(cherry picked from commit 6b30844)
ephraimbuddy
pushed a commit
that referenced
this pull request
Mar 26, 2022
(cherry picked from commit 6b30844)
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it should check if the compared item is the instance of
ResourcesOtherwise, the scheduler won't be able to serialize tasks with
resourcesparams, due to the following error:^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.