Skip to content

Conversation

@Melodie97
Copy link
Contributor


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Feb 5, 2022
@github-actions
Copy link

github-actions bot commented Feb 5, 2022

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@Melodie97 Melodie97 force-pushed the readme branch 2 times, most recently from a2c833d to c8862f3 Compare February 8, 2022 08:54
@Melodie97
Copy link
Contributor Author

@potiuk , pls review

@Melodie97
Copy link
Contributor Author

@potiuk It's showing that static checks are failing here but it didn't show this in my local environment after I used pre-commit, also the error description says this has something to do with run mypy

@potiuk
Copy link
Member

potiuk commented Feb 10, 2022

Just rebase. Good way to try the new "Update with rebase" feature of GitHub that makes it sooooo much easier:

image

@potiuk potiuk merged commit 0d52e77 into apache:main Feb 10, 2022
ferruzzi pushed a commit to ferruzzi/airflow that referenced this pull request Feb 11, 2022
@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants