Skip to content

Conversation

@ashb
Copy link
Member

@ashb ashb commented Feb 3, 2022

We don't need to detatch or background it, as sshd does that by default


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@ashb ashb requested review from mik-laj and potiuk as code owners February 3, 2022 12:55
@ashb ashb added the full tests needed We need to run full set of tests for this PR to merge label Feb 3, 2022
@ashb
Copy link
Member Author

ashb commented Feb 3, 2022

This might give us a clue as to what the problem is? 🤞🏻

@ashb ashb closed this Feb 3, 2022
@ashb ashb reopened this Feb 3, 2022
@ashb
Copy link
Member Author

ashb commented Feb 3, 2022

Well that's unexpected. By running it this way.... it's not erroring? I'll double check and re-run a couple of times, and if that is the case try running without putting logs to stderr (which messes up the test output a bit)

We don't need to detatch or background it, as sshd does that by default
@ashb ashb force-pushed the increase-sshd-ci-logs branch from 08c1c6d to 19459eb Compare February 3, 2022 19:15
@ashb
Copy link
Member Author

ashb commented Feb 3, 2022

I don't think this does anything actually -- main and PRs aren't failing with this SSH error anymore

@uranusjr
Copy link
Member

uranusjr commented Feb 4, 2022

Probably just GitHub having issues. Looking back this seems to coincide with their recent downtime?

@potiuk
Copy link
Member

potiuk commented Feb 4, 2022

Probably just GitHub having issues. Looking back this seems to coincide with their recent downtime?

I don't think so. The downtime was very short (20 minutes or so) and the error started to appear long time before (3-4 days ago). It could have been caused by some changes on the server side. I suspected lack of entropy on the server (that might cause the ssh server to start up for minutes while the keys are generated) but this issue with SSH started to appear about the same time on both Public Runners and our Self-hosted runners, so I suspect this is really some side-effect of other tests we run.

@ashb ashb closed this Feb 4, 2022
@ashb ashb deleted the increase-sshd-ci-logs branch February 4, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants