Cleaner output in docker builds #20747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
area:production-image
Member
Author
|
This PR is based on #20744, so please only check last commit until the previous PR is merged. |
potiuk
force-pushed
the
cleaner-output-in-docker-builds
branch
3 times, most recently
from
b82d349 to
7a260e5
Compare
mik-laj
reviewed
Jan 8, 2022
uranusjr
reviewed
Jan 8, 2022
potiuk
force-pushed
the
cleaner-output-in-docker-builds
branch
2 times, most recently
from
3cf035a to
9e4ddeb
Compare
Member
Author
|
Here are some screenshots of the results: This is the "clean" output (no warning + blue separators for steps in PROD image). I managed to have "red-free" build in normal circumstances (will be important when our image will be come "official image").
This is an example of the CI build where we cannot get rid of the 'root' warning - I just added explanation (once). This is less important to avoid warnings in this case becasue it is purely internal. And while not ideal, it's also not as crucial as PROD image:
|
There was some "junk" output generated by the scripts that are used in Airflow image building. The junk has been cleaned up so that no unnecessary warnings are generated. This change includes: * making sure that when everything is fine, there are no warnnings generated by PROD docker build proces * making sure that when CI image is build the only remaining warning is "Using root" - this warning cannot be silenced pypa/pip#10556 and instead in CI build we explain in green that this is invalid warning * the "scripted" steps of docker build have nicely blue headers that visually separate steps of building the iamge and give more information on what's going on * the current way of printing ouput will play very nicely with BUILDKIT UI where Blue color indicates progress in building Separated out from apache#20238
potiuk
force-pushed
the
cleaner-output-in-docker-builds
branch
from
9e4ddeb to
c8ddc38
Compare
1 task
uranusjr
approved these changes
Jan 10, 2022
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
potiuk
added
the
changelog:skip
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
There was some "junk" output generated by the scripts that are used in Airflow image building. The junk has been cleaned up so that no unnecessary warnings are generated. This change includes: * making sure that when everything is fine, there are no warnnings generated by PROD docker build proces * making sure that when CI image is build the only remaining warning is "Using root" - this warning cannot be silenced pypa/pip#10556 and instead in CI build we explain in green that this is invalid warning * the "scripted" steps of docker build have nicely blue headers that visually separate steps of building the iamge and give more information on what's going on * the current way of printing ouput will play very nicely with BUILDKIT UI where Blue color indicates progress in building Separated out from #20238 (cherry picked from commit 4d33ebf)
jedcunningham
pushed a commit
that referenced
this pull request
Jan 27, 2022
There was some "junk" output generated by the scripts that are used in Airflow image building. The junk has been cleaned up so that no unnecessary warnings are generated. This change includes: * making sure that when everything is fine, there are no warnnings generated by PROD docker build proces * making sure that when CI image is build the only remaining warning is "Using root" - this warning cannot be silenced pypa/pip#10556 and instead in CI build we explain in green that this is invalid warning * the "scripted" steps of docker build have nicely blue headers that visually separate steps of building the iamge and give more information on what's going on * the current way of printing ouput will play very nicely with BUILDKIT UI where Blue color indicates progress in building Separated out from #20238 (cherry picked from commit 4d33ebf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some "junk" output generated by the scripts that are
used in Airflow image building. The junk has been cleaned up so
that no unnecessary warnings are generated.
This change includes:
making sure that when everything is fine, there are no
warnnings generated by PROD docker build proces
making sure that when CI image is build the only remaining
warning is "Using root" - this warning cannot be silenced
Add an opt-out for the “running as root” warning pypa/pip#10556 and instead
in CI build we explain in green that this is invalid warning
the "scripted" steps of docker build have nicely blue headers
that visually separate steps of building the iamge and give
more information on what's going on
the current way of printing ouput will play very nicely with
BUILDKIT UI where Blue color indicates progress in building
Separated out from #20238
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.