Cleaner output of docker image building scripts #20679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
ashb,
jedcunningham,
kaxil and
mik-laj
as code owners
boring-cyborg
bot
added
area:dev-tools
area:production-image
potiuk
force-pushed
the
cleaner-output-of-docker-image-building-scripts
branch
2 times, most recently
from
372b765 to
e3990ac
Compare
ashb
approved these changes
Jan 5, 2022
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
Minor comment, then this second commit LGTM.
scripts/docker/compile_www_assets.sh
Outdated
Member
There was a problem hiding this comment.
File left around on error exit - does it matter?
Member
Author
There was a problem hiding this comment.
Not much, but I will remove it.
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
* removes PIP_INSTALL_USER variable * upgrades PIP to 21.3.1 * removes AIRFLOW_INSTALL_USER_FLAG as it is not needed * removes spurious usage of --upgrade flag for PIP * adds better diagnostics during the build for PIP location and version Separated out from apache#20238
There was some "junk" output generated by the scripts that are used in Airflow image building. The junk has been cleaned up so that no unnecessary warnings are generated. Separated out from apache#20238
potiuk
force-pushed
the
cleaner-output-of-docker-image-building-scripts
branch
from
e3990ac to
f69b96a
Compare
uranusjr
approved these changes
Jan 6, 2022
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jan 6, 2022
This reverts commit fb87800.
potiuk
added a commit
that referenced
this pull request
Jan 6, 2022
This was referenced Jan 6, 2022
potiuk
added
the
changelog:skip
potiuk
added a commit
that referenced
this pull request
Jan 22, 2022
(cherry picked from commit fb87800)
jedcunningham
pushed a commit
that referenced
this pull request
Jan 27, 2022
(cherry picked from commit fb87800)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some "junk" output generated by the scripts that are
used in Airflow image building. The junk has been cleaned up so
that no unnecessary warnings are generated.
Separated out from #20238
Based on #20678 - so please take a look at the last commit only.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.