Modernizes usage of PIP in Airflow images #20678
Conversation
potiuk
requested review from
ashb,
jedcunningham,
kaxil and
mik-laj
as code owners
boring-cyborg
bot
added
area:dev-tools
area:production-image
potiuk
force-pushed
the
modernize-pip-usage-in-images
branch
from
6718b6d to
4fd118f
Compare
potiuk
force-pushed
the
modernize-pip-usage-in-images
branch
from
4fd118f to
80b3b48
Compare
uranusjr
left a comment
uranusjr
left a comment
There was a problem hiding this comment.
Mostly lgtm, just some very minor questions.
potiuk
force-pushed
the
modernize-pip-usage-in-images
branch
from
80b3b48 to
113ca34
Compare
|
All should be addressed. |
potiuk
force-pushed
the
modernize-pip-usage-in-images
branch
from
113ca34 to
21cb191
Compare
* removes PIP_INSTALL_USER variable * upgrades PIP to 21.3.1 * removes AIRFLOW_INSTALL_USER_FLAG as it is not needed * removes spurious usage of --upgrade flag for PIP * adds better diagnostics during the build for PIP location and version Separated out from apache#20238
potiuk
force-pushed
the
modernize-pip-usage-in-images
branch
from
21cb191 to
fefcf7b
Compare
|
Addressed. |
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
|
Covered by #20679. |
|
For the future - @uranusjr - > I wanted to merge those two separately. They contained a lot of context in the "commit messages" and i separated them out deliberately (and planned to merge #20678 first and rebase #20679 on top). By squashing those two - we lost the context in the commit messages and all the changes were squashed :( . |
|
We use to (and I did in #20679) write this kind of message when split out bigger work into separate commits: |
3 participants
Separated out from #20238
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.