Skip to content

[AIRFLOW-796] Config options for num_runs, processor_poll_interval, log_level#2014

Closed
gsakkis wants to merge 1 commit intoapache:masterfrom
Avocarrot:config-options
Closed

[AIRFLOW-796] Config options for num_runs, processor_poll_interval, log_level#2014
gsakkis wants to merge 1 commit intoapache:masterfrom
Avocarrot:config-options

Conversation

@gsakkis
Copy link
Copy Markdown
Contributor

@gsakkis gsakkis commented Jan 23, 2017 •
edited
Loading

Dear Airflow Maintainers,

Please accept this PR that addresses the following issues:

Note: please ignore the first commit, it is covered by #2013

@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 23, 2017 •
edited
Loading

Codecov Report

Merging #2014 into master will increase coverage by 0.01%.

@@            Coverage Diff             @@
##           master    #2014      +/-   ##
==========================================
+ Coverage   66.94%   66.96%   +0.01%     
==========================================
  Files         138      138              
  Lines       10526    10525       -1     
==========================================
+ Hits         7047     7048       +1     
+ Misses       3479     3477       -2
Impacted Files Coverage Δ
airflow/bin/cli.py 53.18% <ø> (ø) ✅
airflow/jobs.py 72.95% <ø> (+0.36%) ✅
airflow/configuration.py 84.42% <ø> (ø) ✅
airflow/settings.py 93.05% <100%> (+0.09%) ✅
airflow/models.py 86.05% <ø> (-0.11%) ❌

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 973f7d6...e0d2b48. Read the comment docs.

@jhsenjaliya
Copy link
Copy Markdown

jhsenjaliya commented Jan 23, 2017

@gsakkis , you should squash all commits and update commit msg and PR title according to the guidelines. ref other PRs if you need any reference. Thanks

@gsakkis
Copy link
Copy Markdown
Contributor Author

gsakkis commented Jan 24, 2017

Commits squashed

@bolkedebruin
Copy link
Copy Markdown
Contributor

bolkedebruin commented Jan 27, 2017

Marking this for 1.8.1

@gsakkis gsakkis changed the title Config options for num_runs, processor_poll_interval, log_level [AIRFLOW-796] Config options for num_runs, processor_poll_interval, log_level Jan 29, 2017
@bolkedebruin
Copy link
Copy Markdown
Contributor

bolkedebruin commented Feb 2, 2017

@gsakkis can you please rebase?

@gsakkis
[AIRFLOW-796] Make more settings configurable
e0d2b48 
- Add num_runs, processor_poll_interval and log_level to config
- Fix the default run_duration and num_runs in the cli
@gsakkis
Copy link
Copy Markdown
Contributor Author

gsakkis commented Feb 2, 2017

@bolkedebruin commit rebased

@gsakkis
Copy link
Copy Markdown
Contributor Author

gsakkis commented Feb 14, 2017

@bolkedebruin any update on this?

@ejconlon
Copy link
Copy Markdown

ejconlon commented May 5, 2017 •
edited
Loading

Making processor_poll_interval configurable would go a long way toward taming scheduler log spew (which is easily 10GB/week for a small instance I'm running). Can we get this change in?

@stale
Copy link
Copy Markdown

stale Bot commented Dec 11, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 11, 2018
@gsakkis
Copy link
Copy Markdown
Contributor Author

gsakkis commented Dec 11, 2018

Bump

@stale stale Bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 11, 2018
@ashb
Copy link
Copy Markdown
Member

ashb commented Dec 11, 2018

Log_level iss now a config setting.

Remove that, rebase, and test that setting the scheduler job interval still works, then ping be and I can merge.

@ashb
Copy link
Copy Markdown
Member

ashb commented Dec 11, 2018

(And sorry for leaving the PR for so long. I realise you've already rebased once and nothing happened. Sorry)

@XD-DENG
Copy link
Copy Markdown
Member

XD-DENG commented Jan 15, 2019

@gsakkis FYI: run_duration is removed since 327860f#diff-1c2404a3a60f829127232842250ff406

@OmerJog
Copy link
Copy Markdown
Contributor

OmerJog commented Mar 6, 2019

num_runs is also planned to be removed https://issues.apache.org/jira/browse/AIRFLOW-3533

@gsakkis gsakkis closed this Mar 30, 2019
@gsakkis gsakkis deleted the config-options branch March 30, 2019 09:33
@gsakkis gsakkis mentioned this pull request Mar 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gsakkis @codecov-io @jhsenjaliya @bolkedebruin @ejconlon @ashb @XD-DENG @OmerJog