Needs also a fix to the static tests of PostgresHook https://github.com/apache/airflow/runs/4303759942?check_suite_focus=true#step:10:163

Thanks, fixed.

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

I guess then tests also have to be reverted since those are expecting region_name to be passed now?
We a bit overthought this change. If there's so much opportunity for refactoring its worth a separate PR altogether for that kind of work in general.

No, the tests were only failing because they checked for resource_type and client_type arguments that you removed. The additions to the public API do not affect tests (because they are optional).

Hmm, what are these AttributeError: 'S3' object has no attribute 'Object' errors about?

An error occurred (404) when calling the HeadObject operation: Not Found

So calling _get_credentials(region_name=None) does not work after all?

An error occurred (404) when calling the HeadObject operation: Not Found

So calling _get_credentials(region_name=None) does not work after all?

Mmm woot :/
Not on my laptop so cant take a look :(

I think we should revert #19725 first as it breaks main branch (static checks) and figure it out after...

https://github.com/apache/airflow/pull/19725/files#diff-3bd25af5c6450acdcccdd9e5da7372ea6c243b716ab1ce0436f39b4c07b8f5de
Replace in both s3 methods
session.client(
to
session.resource(

Giving this one last shot. If it does not work, revert is available in #19791.

We’re do this again from scratch.

New PR in #19815