Skip to content

Conversation

@ChanglinZhou
Copy link
Contributor

@ChanglinZhou ChanglinZhou commented Oct 25, 2021

Do not iterate all the processing jobs, because it's problematic.

closes: #16763

related #19066

SagemakerProcessingOperator ThrottlingException
@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Oct 25, 2021
Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Oct 26, 2021
@uranusjr
Copy link
Member

Need to fix the static checks.

All changes made by hooks:
diff --git a/airflow/providers/amazon/aws/operators/sagemaker_processing.py b/airflow/providers/amazon/aws/operators/sagemaker_processing.py
index 53cb648..529fb5d 100644
--- a/airflow/providers/amazon/aws/operators/sagemaker_processing.py
+++ b/airflow/providers/amazon/aws/operators/sagemaker_processing.py
@@ -98,8 +98,8 @@ class SageMakerProcessingOperator(SageMakerBaseOperator):
 
         if self.hook.find_processing_job_by_name(processing_job_name):
             raise AirflowException(
-                    f"A SageMaker processing job with name {processing_job_name} already exists."
-                )
+                f"A SageMaker processing job with name {processing_job_name} already exists."
+            )
 
         self.log.info("Creating SageMaker processing job %s.", self.config["ProcessingJobName"])
         response = self.hook.create_processing_job(

@ChanglinZhou
Copy link
Contributor Author

ChanglinZhou commented Oct 27, 2021

Sorry, I am not familiar with the airflow dev workflow, some test cases are not passed, So I need fix them. @uranusjr

@eladkal eladkal changed the title SagemakerProcessingOperator ThrottlingException #16763 #19066 fix SagemakerProcessingOperator ThrottlingException Oct 28, 2021
@ChanglinZhou ChanglinZhou requested a review from eladkal October 28, 2021 15:04
@ChanglinZhou
Copy link
Contributor Author

Fix indention.

@ChanglinZhou
Copy link
Contributor Author

Sorry, I failed to setup the dev env.

@ChanglinZhou
Copy link
Contributor Author

My change doesn't touch the quarantined tests. Please merge it.

@ChanglinZhou
Copy link
Contributor Author

I have tried the GitHub.com/apache/airflow main branch, the quarantined test fails.

@eladkal eladkal merged commit 96dd703 into apache:main Nov 4, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 4, 2021

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers okay to merge It's ok to merge this PR as it does not require more tests provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SagemakerProcessingOperator ThrottlingException

4 participants