-
Notifications
You must be signed in to change notification settings - Fork 16.3k
fix SagemakerProcessingOperator ThrottlingException #19195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SagemakerProcessingOperator ThrottlingException
SagemakerProcessingOperator ThrottlingException
uranusjr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming tests pass
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
|
Need to fix the static checks. All changes made by hooks:
diff --git a/airflow/providers/amazon/aws/operators/sagemaker_processing.py b/airflow/providers/amazon/aws/operators/sagemaker_processing.py
index 53cb648..529fb5d 100644
--- a/airflow/providers/amazon/aws/operators/sagemaker_processing.py
+++ b/airflow/providers/amazon/aws/operators/sagemaker_processing.py
@@ -98,8 +98,8 @@ class SageMakerProcessingOperator(SageMakerBaseOperator):
if self.hook.find_processing_job_by_name(processing_job_name):
raise AirflowException(
- f"A SageMaker processing job with name {processing_job_name} already exists."
- )
+ f"A SageMaker processing job with name {processing_job_name} already exists."
+ )
self.log.info("Creating SageMaker processing job %s.", self.config["ProcessingJobName"])
response = self.hook.create_processing_job( |
|
Sorry, I am not familiar with the airflow dev workflow, some test cases are not passed, So I need fix them. @uranusjr |
|
Fix indention. |
|
Sorry, I failed to setup the dev env. |
|
My change doesn't touch the quarantined tests. Please merge it. |
|
I have tried the GitHub.com/apache/airflow main branch, the quarantined test fails. |
|
Awesome work, congrats on your first merged pull request! |
Do not iterate all the processing jobs, because it's problematic.
closes: #16763
related #19066