Skip to content

Conversation

@sharon2719
Copy link

@sharon2719 sharon2719 commented Oct 13, 2021

closes: #8194


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 13, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@sharon2719
Copy link
Author

sharon2719 commented Oct 14, 2021 via email

@sharon2719
Copy link
Author

I am now beginning to get what i need to do in the docs. thanks for the breakdown

@eladkal
Copy link
Contributor

eladkal commented Oct 14, 2021

Do you mind if you can assist me on that issue?

Sure. The goal is to explain the users how to setup the classes in https://github.com/apache/airflow/blob/main/airflow/providers/apache/pinot/hooks/pinot.py
explain about the parameters / diffrent configurations / tips / anything else that worth mentioning.
You can create example dags and incorporate it into the guide.
You can look up our documentation for guides that we have on other operators/hook.

@sharon2719
Copy link
Author

sharon2719 commented Oct 14, 2021 via email

@sharon2719
Copy link
Author

sharon2719 commented Oct 16, 2021 via email

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM :)
Left some comments to address

@josh-fell can you take a look at the example DAG?

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Oct 16, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@eladkal eladkal changed the title pinot operators guide #8194 Add Guide for Apache Pinot Oct 16, 2021
Copy link
Author

@sharon2719 sharon2719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed already

Copy link
Author

@sharon2719 sharon2719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed already

@uranusjr
Copy link
Member

Was the =2.1.0 file accidentally committed?

@potiuk
Copy link
Member

potiuk commented Oct 27, 2021

Was the =2.1.0 file accidentally committed?

I wen't ahead and deleted it via Github UI :). Nice catch @uranusjr

@eladkal
Copy link
Contributor

eladkal commented Oct 27, 2021

I think there are unrelated changes in that PR.
Why there are changes to airflow/_vendor/connexion/ ?

@potiuk
Copy link
Member

potiuk commented Oct 27, 2021

Why there are changes to airflow/_vendor/connexion/ ?

Indeed - should be removed.

@uranusjr
Copy link
Member

It seems like the merge (or rebase?) didn't went well and pulled in a ton of unrelated things...

@sharon2719
Copy link
Author

sharon2719 commented Oct 28, 2021

I have rebased it but I still dont get why it is still pushing with the unrelated changes

@sharon2719 sharon2719 closed this Oct 28, 2021
@sharon2719 sharon2719 reopened this Oct 28, 2021
@uranusjr
Copy link
Member

uranusjr commented Oct 28, 2021

I think this is rebased to the wrong base. Not sure what the best way to recover is; personally I usually cherry-pick the commits manually back:

# Assumes 'origin' points to apache/airflow -- adjust 'origin' as needed.
git fetch origin main
git branch -f main origin/main  # Point the local 'main' to the origin's main.
git checkout main
git cherry-pick e700a59ae85beb7bbfbd25153b4d9eeb3c78a9d8  # Manully apply the commit's changes again.
git push --force

To avoid this from happening again, it is best to avoid making changes on your own 'main' directly, but instead create a branch for each pull request. Since this PR is already submitted, it is not possible to change the originating branch now, but this is a good approach to remember if you plan to make other pull requests in the future.

@sharon2719 sharon2719 closed this Nov 4, 2021
@sharon2719 sharon2719 reopened this Nov 4, 2021
@sharon2719 sharon2719 closed this Nov 4, 2021
@sharon2719 sharon2719 deleted the Resove_conflicts branch November 4, 2021 18:00
@sharon2719 sharon2719 restored the Resove_conflicts branch November 4, 2021 18:01
@sharon2719 sharon2719 reopened this Nov 4, 2021
@eladkal
Copy link
Contributor

eladkal commented Nov 4, 2021

@sharon2719 There are still many unrelated changes in the branch (lower than before tough) please remove all unrelated code changes you can see in https://github.com/apache/airflow/pull/18930/files the files that you are modifying

@sharon2719 sharon2719 closed this Nov 10, 2021
@sharon2719 sharon2719 deleted the Resove_conflicts branch November 10, 2021 06:32
@sharon2719 sharon2719 restored the Resove_conflicts branch November 10, 2021 06:36
@sharon2719 sharon2719 reopened this Nov 10, 2021
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Dec 26, 2021
@github-actions github-actions bot closed this Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers kind:documentation okay to merge It's ok to merge this PR as it does not require more tests stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guide for Apache Pinot operators