-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add Guide for Apache Pinot #18930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Guide for Apache Pinot #18930
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Co-authored-by: Theofanis Despoudis <[email protected]>
Co-authored-by: Theofanis Despoudis <[email protected]>
|
I am now beginning to get what i need to do in the docs. thanks for the breakdown |
Sure. The goal is to explain the users how to setup the classes in https://github.com/apache/airflow/blob/main/airflow/providers/apache/pinot/hooks/pinot.py |
|
Thank you for your response i will implement the feedback and give
you feedback on how it is going to work
…On Thu, Oct 14, 2021, 10:41 PM eladkal ***@***.***> wrote:
Do you mind if you can assist me on that issue?
Sure. The goal is to explain the users how to setup the classes in
https://github.com/apache/airflow/blob/main/airflow/providers/apache/pinot/hooks/pinot.py
explain about the parameters / diffrent configurations / tips / anything
else that worth mentioning.
You can create example dags and incorporate it into the guide.
You can look up our documentation for guides that we have on other
operators/hook.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18930 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AS3ZWV4EU4KKNGFGJSAOFE3UG4W6HANCNFSM5F4IANHQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Hello Elad,
I have been able to do the changes. Kindly check it out.
Regards
…On Thu, 14 Oct 2021 at 22:43, Sharon Akinyi ***@***.***> wrote:
Thank you for your response i will implement the feedback and give
you feedback on how it is going to work
On Thu, Oct 14, 2021, 10:41 PM eladkal ***@***.***> wrote:
> Do you mind if you can assist me on that issue?
>
> Sure. The goal is to explain the users how to setup the classes in
> https://github.com/apache/airflow/blob/main/airflow/providers/apache/pinot/hooks/pinot.py
> explain about the parameters / diffrent configurations / tips / anything
> else that worth mentioning.
> You can create example dags and incorporate it into the guide.
> You can look up our documentation for guides that we have on other
> operators/hook.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#18930 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AS3ZWV4EU4KKNGFGJSAOFE3UG4W6HANCNFSM5F4IANHQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
|
eladkal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM :)
Left some comments to address
@josh-fell can you take a look at the example DAG?
airflow/providers/apache/pinot/example_dags/example_pinot_dag.py
Outdated
Show resolved
Hide resolved
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
sharon2719
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed already
sharon2719
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed already
|
Was the |
I wen't ahead and deleted it via Github UI :). Nice catch @uranusjr |
|
I think there are unrelated changes in that PR. |
Indeed - should be removed. |
|
It seems like the merge (or rebase?) didn't went well and pulled in a ton of unrelated things... |
|
I have rebased it but I still dont get why it is still pushing with the unrelated changes |
|
I think this is rebased to the wrong base. Not sure what the best way to recover is; personally I usually # Assumes 'origin' points to apache/airflow -- adjust 'origin' as needed.
git fetch origin main
git branch -f main origin/main # Point the local 'main' to the origin's main.
git checkout main
git cherry-pick e700a59ae85beb7bbfbd25153b4d9eeb3c78a9d8 # Manully apply the commit's changes again.
git push --forceTo avoid this from happening again, it is best to avoid making changes on your own 'main' directly, but instead create a branch for each pull request. Since this PR is already submitted, it is not possible to change the originating branch now, but this is a good approach to remember if you plan to make other pull requests in the future. |
|
@sharon2719 There are still many unrelated changes in the branch (lower than before tough) please remove all unrelated code changes you can see in https://github.com/apache/airflow/pull/18930/files the files that you are modifying |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
closes: #8194
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.