Backport fix to allow pickling of Loggers to Python 3.6 #18798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sending objects around via multiprocessing (on Python 3.6 or lower) it would fail if that object contained a Logger object. To fix that we have "backported" the change in Python 3.7 to make Logger objects be pickled "by name". (In Python 3.7 the change adds `__reduce__` methods on to the Logger and RootLogger objects, but here we achieve it `copyreg` stdlib module so we don't monkeypatch anything.) This mainly applies to using Kubernetes client >12 (which is not currently possible as we restrict that version) but this adds support for it anywhere it might happen inside Python 3.6.
ashb
added
the
full tests needed
kaxil
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending objects around via multiprocessing (on Python 3.6 or lower)
it would fail if that object contained a Logger object.
To fix that we have "backported" the change in Python 3.7 to make Logger
objects be pickled "by name". (In Python 3.7 the change adds
__reduce__methods on to the Logger and RootLogger objects, but herewe achieve it
copyregstdlib module so we don't monkeypatchanything.)
This mainly applies to using Kubernetes client >12 (which is not
currently possible as we restrict that version) but this adds support
for it anywhere it might happen inside Python 3.6.