Add/Update Snowflake SQL Operators #18413
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add SnowflakeThresholdCheckOperator and BranchSnowflakeOperator based on corresponding SQL operators. These operators round out the functionality provided by SQL operators for Snowflake. Additionally, the SnowflakeIntervalCheckOperator parameter list is updated.
denimalpaca
requested review from
mik-laj,
potiuk and
turbaszek
as code owners
boring-cyborg
bot
added
area:providers
provider:snowflake
eladkal
reviewed
Sep 21, 2021
| return get_db_hook(self) | ||
|
|
||
|
|
||
| class BranchSnowflakeOperator(BranchSQLOperator): |
Contributor
There was a problem hiding this comment.
Wouldn't an approch like https://github.com/apache/airflow/pull/18394/files be better?
Saves the trouble of setting up unique classes specifically for Snowflake
Contributor
Author
There was a problem hiding this comment.
I like this solution a lot, would also handle all the other cases (BigQuery specifically, which this and my last PR was based on). Seems like it would make more sense for me to open a separate PR for that solution, though.
Contributor
|
Closed in favor of #18718 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
SnowflakeThresholdOperatorandBranchSnowflakeOperatorTwo new operators are added for Snowflake to match the full suite of SQL Operators doing checks and branches. Slight updates to other Snowflake Operators included.