Fix blank dag dependencies view #17990
Conversation
boring-cyborg
bot
added
area:UI
|
P.S If this makes sense then we probably should remove the class method |
|
I would guess that the thinking here is that "if none of the serialized dags have changed, then there is no point recalculating the graph" |
|
CC: @ms32035 |
|
Ok. Instead, I updated to calculate the graph when there isn't already node or edge data. |
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
2 participants
When there is an issue with the scheduler
max_last_updatedmay be older thanlast_refreshand thereforecalculate_graphwas never being called leaving thenodesandedgesto be blank.Removing it allows us to calculate the nodes and edges even in that circumstance.Update: I added a check to calculate the graph when there isn't already node or edge data.
Bonus: Make the
last_refreshchange with the app's timezone like all other dates.Closes #16610
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.