AwsBaseHook make client_type & resource_type optional params for get_client_type & get_resource_type
#17987
Conversation
boring-cyborg
bot
added
area:providers
provider:amazon
eladkal
requested review from
feluelle,
kaxil,
potiuk,
uranusjr and
xinbinhuang
|
It will be even better! if we can refactor them somehow, it seems really confusing to me to have |
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
eladkal
changed the title
client_type & resource_type optional params for get_client_type & get_resource_type
|
As suggested I added deprecation for
The values should be set only from the hook |
3 participants
Currently user must specify
client_typeto forget_client_typeso an example usage is:emr_client = AwsBaseHook(self.aws_conn_id, client_type='emr', region_name='us-east-1').get_client_type('emr')however we already have
client_typeas class attribute so we can simplify it to:emr_client = AwsBaseHook(self.aws_conn_id, client_type='emr', region_name='us-east-1').get_client_type()EDIT:
Same applied for
resource_typewithget_resource_type^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.