Validate that the extra parameter is parseable as JSON #15146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
reviewed
Apr 2, 2021
airflow/models/connection.py
Outdated
Contributor
There was a problem hiding this comment.
@mik-laj has suggested we should forbid the case where json.loads(extra) produces a list or primitive
anyone else agree with that?
mik-laj
reviewed
Apr 3, 2021
davlum
force-pushed
the
upkeep/add-query-parameter-validation-on-connection
branch
from
275efab to
e8ba6e1
Compare
Contributor
|
Hey @davlum, been a minute! Could you add a unit test? After that I'm good to merge. |
Contributor
|
alternatively we could continute to allow users to put arbitrary string in |
davlum
force-pushed
the
upkeep/add-query-parameter-validation-on-connection
branch
from
e8ba6e1 to
96c38e3
Compare
Contributor
Author
|
@dimberman waddup! Added tests but tbh I'm also down for what @dstandish suggested. It would be more backwards compat. |
Before this commit there was a documented but unenforced limitation that the extra parameter be encoded JSON. In apache#15013 this issue garnered attention and motivated this PR.
davlum
force-pushed
the
upkeep/add-query-parameter-validation-on-connection
branch
from
96c38e3 to
0e99f96
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit there was a documented but unenforced
limitation that the extra parameter be encoded JSON.
In #15013 this issue garnered attention and motivated
this PR.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.