Allow multiple statements executions and return info of executions SnowflakeHook #15128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:snowflake
uranusjr
reviewed
Apr 1, 2021
| else: | ||
| self.log.info(query) | ||
| cur.execute(query) | ||
| for row in cur.fetchall(): |
Member
There was a problem hiding this comment.
Suggested change
| for row in cur.fetchall(): | |
| for row in cur: |
More memory efficient.
| # If autocommit was set to False for db that supports autocommit, | ||
| # or if db does not supports autocommit, we do a manual commit. | ||
| if not self.get_autocommit(conn): | ||
| conn.commit() |
Member
There was a problem hiding this comment.
I believe the standard way to do this is on the cursor before closing instead. The get_autocommit() check is also not needed since commit() is a no-op in autocommit mode.
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
Contributor
|
The functionality was added in #15533 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow multiple statements executions and return info of executions SnowflakeHook