-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Merge pull request #1 from airbnb/master #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to master
zack3241
pushed a commit
to zack3241/incubator-airflow
that referenced
this pull request
Jan 25, 2018
# This is a combination of 16 commits.
# This is the 1st commit message:
Add flask_admin_unescape function to airfow.www.utils
# This is the commit message apache#2:
Add flask_admin_unescape to TaskInstanceModelView for task_id and dag_id
# This is the commit message apache#3:
Add test_flask_admin_unescape to tests.www.test_utils
# This is the commit message apache#4:
Add TestTaskInstanceModelView to tests.www.test_views
This test for the proper integration between Subdag Tasks and the
flask_admin package. Because the flask_admin package uses '.'
characters as it's escape character and airflow enforces the
dag_id.subdag_id format for the dag_id's for task_id's in subdags,
the escaping that flask_admin preforms causes a duplication of the
'.' character. When perform the actions that are available for those
task_instances via the ui, this causes an error. These tests are
here to protect against that integration issue.
# This is the commit message apache#5:
Update airflow.www.utils to conform to flake8 standards
# This is the commit message apache#6:
Update tests.www.test_utils to conform to flake8 standards
# This is the commit message apache#7:
Update TestTaskInstanceModelView to Leverage assertEqual
# This is the commit message apache#8:
Remove Superfluous SubDAG Task Var TestTaskInstanceModelView
# This is the commit message apache#9:
Update airflow.www.utils.gizipped.view_func to match with flake8
# This is the commit message apache#11:
Update airflow.www._connection_ids to align with flake8 spacing
# This is the commit message apache#12:
Update tests.www.test_utils.test_flask_admin_unescape with proper spaces
# This is the commit message apache#13:
Align tests.www.test_views with flake8 standards
# This is the commit message apache#14:
Remove unnecessary SubDagOperator in tests.www.test_views
# This is the commit message apache#15:
Change Position on install_aliases call in www.utils for flake8
# This is the commit message apache#16:
Separate setting subdag state via flask_admin model tests
mobuchowski
pushed a commit
to mobuchowski/airflow
that referenced
this pull request
Jan 4, 2022
seanghaeli
referenced
this pull request
in aws-mwaa/upstream-to-airflow
Aug 7, 2025
author Sean Ghaeli <[email protected]> 1754492517 -0700 committer Sean Ghaeli <[email protected]> 1754608125 -0700 parent b22b1a6 author Sean Ghaeli <[email protected]> 1754492517 -0700 committer Sean Ghaeli <[email protected]> 1754608106 -0700 # This is a combination of 18 commits. # This is the 1st commit message: Shared client pool for base waiter and thread safe client pooling # This is the commit message #2: working smus test # This is the commit message #3: format ECS run_task API call correctly for env vars # This is the commit message #4: Make test filename equal to Dag ID # This is the commit message #5: Format env variables for ECS run_task correctly # This is the commit message #6: Have dag name match the test file name # This is the commit message #7: verbose logging # This is the commit message #8: with logging # This is the commit message #9: debugs on ecs executor # This is the commit message #10: wrap container overrides in a list according to docs # This is the commit message #11: no need to typecast string # This is the commit message #12: new logs # This is the commit message #13: name param must be defined in containeroverrides # This is the commit message #14: new logs # This is the commit message #15: Use correct ECS executor container name # This is the commit message #16: new logging # This is the commit message #17: remove unecessary logs not to be included in PR # This is the commit message #18: Remove redundant ECS executor logs cache aiobotocore client per trigger instance with async context manager Thread safe client pooling Thread safe client pooling type annotation for client pool dict type annotation for client pool dict
seanghaeli
referenced
this pull request
in aws-mwaa/upstream-to-airflow
Aug 7, 2025
author Sean Ghaeli <[email protected]> 1754492517 -0700 committer Sean Ghaeli <[email protected]> 1754608125 -0700 parent b22b1a6 author Sean Ghaeli <[email protected]> 1754492517 -0700 committer Sean Ghaeli <[email protected]> 1754608106 -0700 # This is a combination of 18 commits. # This is the 1st commit message: Shared client pool for base waiter and thread safe client pooling # This is the commit message #2: working smus test # This is the commit message #3: format ECS run_task API call correctly for env vars # This is the commit message #4: Make test filename equal to Dag ID # This is the commit message #5: Format env variables for ECS run_task correctly # This is the commit message #6: Have dag name match the test file name # This is the commit message #7: verbose logging # This is the commit message #8: with logging # This is the commit message #9: debugs on ecs executor # This is the commit message #10: wrap container overrides in a list according to docs # This is the commit message #11: no need to typecast string # This is the commit message #12: new logs # This is the commit message #13: name param must be defined in containeroverrides # This is the commit message #14: new logs # This is the commit message #15: Use correct ECS executor container name # This is the commit message #16: new logging # This is the commit message #17: remove unecessary logs not to be included in PR # This is the commit message #18: Remove redundant ECS executor logs cache aiobotocore client per trigger instance with async context manager Thread safe client pooling Thread safe client pooling type annotation for client pool dict type annotation for client pool dict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to master