Better diagnostics for image waiting #14779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
better-diagnostics-for-image-waiting
branch
2 times, most recently
from
6756614 to
9d36ca0
Compare
Sometimes (very rarely) some 'wait for image' pulling steps loop forever (while other steps from parallell jobs pulling the same image have no problems). Example here: Failed step here: * https://github.com/apache/airflow/runs/2106723280?check_suite_focus=true#step:5:349 Another similar step in parallel job had no problems with retrieving the same image earlier: * https://github.com/apache/airflow/runs/2106723269?check_suite_focus=true#step:5:119 Both images pulled the same image: docker.pkg.github.com/apache/airflow/master-python3.6-ci-v2:651461418 This change adds diagnostics information that might provide more information in case this happens again so that we can understand what is going on and mitigate the issue.
potiuk
force-pushed
the
better-diagnostics-for-image-waiting
branch
from
9d36ca0 to
e80b2fc
Compare
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
added a commit
that referenced
this pull request
Mar 23, 2021
Sometimes (very rarely) some 'wait for image' pulling steps loop forever (while other steps from parallell jobs pulling the same image have no problems). Example here: Failed step here: * https://github.com/apache/airflow/runs/2106723280?check_suite_focus=true#step:5:349 Another similar step in parallel job had no problems with retrieving the same image earlier: * https://github.com/apache/airflow/runs/2106723269?check_suite_focus=true#step:5:119 Both images pulled the same image: docker.pkg.github.com/apache/airflow/master-python3.6-ci-v2:651461418 This change adds diagnostics information that might provide more information in case this happens again so that we can understand what is going on and mitigate the issue. (cherry picked from commit 4cde47b)
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2021
Sometimes (very rarely) some 'wait for image' pulling steps loop forever (while other steps from parallell jobs pulling the same image have no problems). Example here: Failed step here: * https://github.com/apache/airflow/runs/2106723280?check_suite_focus=true#step:5:349 Another similar step in parallel job had no problems with retrieving the same image earlier: * https://github.com/apache/airflow/runs/2106723269?check_suite_focus=true#step:5:119 Both images pulled the same image: docker.pkg.github.com/apache/airflow/master-python3.6-ci-v2:651461418 This change adds diagnostics information that might provide more information in case this happens again so that we can understand what is going on and mitigate the issue. (cherry picked from commit 4cde47b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes (very rarely) some 'wait for image' pulling steps
loop forever (while other steps from parallell jobs pulling the
same image have no problems).
Example here:
Failed step here:
Another similar step in parallel job had no problems with retrieving the
same image earlier:
Both images pulled the same image:
docker.pkg.github.com/apache/airflow/master-python3.6-ci-v2:651461418
This change adds diagnostics information that might provide more
information in case this happens again so that we can understand
what is going on and mitigate the issue.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.