Add minimum version of pylint #14775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using some pylint rules that were added in pylint 2.7.0, for example `consider-using-generator`. When older version of pylint is used, it fails with this error: * E0012: Bad option value 'consider-using-generator' (bad-option-value) Adding lower-limit forces the pylint to be upgraded even if someone's image or installation already had pylint installed.
potiuk
requested review from
BasPH,
XD-DENG,
ashb,
dstandish,
ephraimbuddy,
kaxil,
mik-laj and
turbaszek
mik-laj
approved these changes
Mar 14, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using some pylint rules that were added in pylint 2.7.0,
for example
consider-using-generator. When older version ofpylint is used, it fails with this error:
Adding lower-limit forces the pylint to be upgraded even if
someone's image or installation already had pylint installed.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.