Remove Heisentest category and quarantine test_backfill_depends_on_past #14756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
The whole Backfill class was in Heisentest but only one of those tests is problematic nowi: test_backfill_depends_on_past. Therfore it makes sense to remove the class from heisentests and move the depends_on_past to quarantine. It turned out that this is the last "Heisentest" and with the isolation we have now coming in parallel tests, it turns out that Heisentests are not really good way thinking about the tests - running them in isolation does not often help, it only makes it more difficult to flag the tests as flaky. The quarantine test_backfill_depends_on_past ihas been captured in the apache#14755 issue - and hopefully we will make an effort to de-quarantine some of those tests soon.
potiuk
force-pushed
the
quarantine-backfill-depends-on-past
branch
from
9b1bab1 to
8ac7936
Compare
potiuk
changed the title
turbaszek
approved these changes
Mar 13, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
added a commit
that referenced
this pull request
Mar 23, 2021
…st (#14756) The whole Backfill class was in Heisentest but only one of those tests is problematic nowi: test_backfill_depends_on_past. Therfore it makes sense to remove the class from heisentests and move the depends_on_past to quarantine. It turned out that this is the last "Heisentest" and with the isolation we have now coming in parallel tests, it turns out that Heisentests are not really good way thinking about the tests - running them in isolation does not often help, it only makes it more difficult to flag the tests as flaky. The quarantine test_backfill_depends_on_past ihas been captured in the #14755 issue - and hopefully we will make an effort to de-quarantine some of those tests soon. (cherry picked from commit 4ce952e)
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2021
…st (#14756) The whole Backfill class was in Heisentest but only one of those tests is problematic nowi: test_backfill_depends_on_past. Therfore it makes sense to remove the class from heisentests and move the depends_on_past to quarantine. It turned out that this is the last "Heisentest" and with the isolation we have now coming in parallel tests, it turns out that Heisentests are not really good way thinking about the tests - running them in isolation does not often help, it only makes it more difficult to flag the tests as flaky. The quarantine test_backfill_depends_on_past ihas been captured in the #14755 issue - and hopefully we will make an effort to de-quarantine some of those tests soon. (cherry picked from commit 4ce952e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole Backfill class was in Heisentest but only one of those tests
is problematic nowi: test_backfill_depends_on_past. Therfore it makes
sense to remove the class from heisentests and move the
depends_on_past to quarantine.
It turned out that this is the last "Heisentest" and with the
isolation we have now coming in parallel tests, it turns out that
Heisentests are not really good way thinking about the tests - running
them in isolation does not often help, it only makes it more difficult
to flag the tests as flaky.
The quarantine test_backfill_depends_on_past ihas been captured in
the #14755 issue - and hopefully we will make an effort to
de-quarantine some of those tests soon.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.