Fixes force-pulling base python images #14736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
fix-force-pulling-base-python-image
branch
from
2333caf to
5fc06b2
Compare
Sometimes base python image patchlevel might case failure of tests. This happens for example with test_views.py tests fixed in apache#14719 where CVE fix in all python versions caused our tests to fail. There was an error in our scripts - when --force-pull-images were used, the base python version was not updated to the latest version even if there was a newer one and it caused our images to bounce few times between two latest patchlevels when they were manually refreshed. This change fixes it so that the base python image is always used when a) FORCE_PULL_IMAGES is true or b) UPGRADE_TO_NEWER_DEPENDENCIES is != false This will cause python upgrade in two cases: - when images are rebuilt with --force-pull-images locally - when images are upgraded with newer dependencies on master
potiuk
force-pushed
the
fix-force-pulling-base-python-image
branch
from
5fc06b2 to
beedf45
Compare
Member
Author
|
Hey @kaxil -> that should permanently fix the similar problems that we had with the python CVE fix recently |
kaxil
approved these changes
Mar 13, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
potiuk
added a commit
that referenced
this pull request
Mar 23, 2021
Sometimes base python image patchlevel might case failure of tests. This happens for example with test_views.py tests fixed in #14719 where CVE fix in all python versions caused our tests to fail. There was an error in our scripts - when --force-pull-images were used, the base python version was not updated to the latest version even if there was a newer one and it caused our images to bounce few times between two latest patchlevels when they were manually refreshed. This change fixes it so that the base python image is always used when a) FORCE_PULL_IMAGES is true or b) UPGRADE_TO_NEWER_DEPENDENCIES is != false This will cause python upgrade in two cases: - when images are rebuilt with --force-pull-images locally - when images are upgraded with newer dependencies on master (cherry picked from commit 61b4482)
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2021
Sometimes base python image patchlevel might case failure of tests. This happens for example with test_views.py tests fixed in #14719 where CVE fix in all python versions caused our tests to fail. There was an error in our scripts - when --force-pull-images were used, the base python version was not updated to the latest version even if there was a newer one and it caused our images to bounce few times between two latest patchlevels when they were manually refreshed. This change fixes it so that the base python image is always used when a) FORCE_PULL_IMAGES is true or b) UPGRADE_TO_NEWER_DEPENDENCIES is != false This will cause python upgrade in two cases: - when images are rebuilt with --force-pull-images locally - when images are upgraded with newer dependencies on master (cherry picked from commit 61b4482)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes base python image patchlevel might case failure of tests.
This happens for example with test_views.py tests fixed in #14719
where CVE fix in all python versions caused our tests to fail.
There was an error in our scripts - when --force-pull-images
were used, the base python version was not updated to the
latest version even if there was a newer one and it caused our
images to bounce few times between two latest patchlevels
when they were manually refreshed.
This change fixes it so that the base python image is always used
when
a) FORCE_PULL_IMAGES is true or
b) UPGRADE_TO_NEWER_DEPENDENCIES is != false
This will cause python upgrade in two cases:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.