Skip to content

Conversation

@gmcrocetti
Copy link
Contributor


Patch for #14669

@boring-cyborg boring-cyborg bot added the provider:microsoft-azure Azure-related issues label Mar 10, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 10, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@gmcrocetti gmcrocetti force-pushed the azure-data-factory-attributes-14669 branch from 9396bb3 to b69ae00 Compare March 11, 2021 14:58
@gmcrocetti gmcrocetti requested review from ashb and potiuk as code owners March 11, 2021 14:58
* Add 'conn_type', 'conn_name_attr', 'default_conn_name' and 'hook_name';
* Change expected_number_of_hooks to 62.

Resolves: apache#14669
@gmcrocetti gmcrocetti force-pushed the azure-data-factory-attributes-14669 branch from b69ae00 to eaa2792 Compare March 12, 2021 02:16
@gmcrocetti
Copy link
Contributor Author

@ashb . Any tips to find out the error ?

@kaxil kaxil merged commit 4372d45 into apache:master Mar 12, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 12, 2021

Awesome work, congrats on your first merged pull request!

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 12, 2021
@gmcrocetti gmcrocetti deleted the azure-data-factory-attributes-14669 branch March 13, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge provider:microsoft-azure Azure-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants