Elasticsearch Provider: Fix logs downloading for tasks #14686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, Webserver fails with:
```
[2021-03-09 18:55:19,640] {base.py:122} INFO - POST http://aa.aa:9200/_count [status:200 request:0.142s]
[2021-03-09 18:55:19 +0000] [64] [ERROR] Error handling request
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/gunicorn/workers/sync.py", line 181, in handle_request
for item in respiter:
File "/usr/local/lib/python3.7/site-packages/werkzeug/wsgi.py", line 506, in __next__
return self._next()
File "/usr/local/lib/python3.7/site-packages/werkzeug/wrappers/base_response.py", line 45, in _iter_encoded
for item in iterable:
File "/usr/local/lib/python3.7/site-packages/airflow/utils/log/log_reader.py", line 84, in read_log_stream
logs, metadata = self.read_log_chunks(ti, current_try_number, metadata)
File "/usr/local/lib/python3.7/site-packages/airflow/utils/log/log_reader.py", line 58, in read_log_chunks
logs, metadatas = self.log_handler.read(ti, try_number, metadata=metadata)
File "/usr/local/lib/python3.7/site-packages/airflow/utils/log/file_task_handler.py", line 217, in read
log, metadata = self._read(task_instance, try_number_element, metadata)
File "/usr/local/lib/python3.7/site-packages/airflow/providers/elasticsearch/log/es_task_handler.py", line 186, in _read
and offset >= metadata['max_offset']
TypeError: '>=' not supported between instances of 'str' and 'int'
```
kaxil
requested review from
XD-DENG,
eladkal,
ephraimbuddy,
jhtimmins and
ryanahamilton
ashb
approved these changes
Mar 9, 2021
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Mar 13, 2021
apache#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately.
kaxil
added a commit
that referenced
this pull request
Mar 13, 2021
#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately.
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2021
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 23, 2021
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 27, 2021
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Mar 10, 2022
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 4, 2022
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 9, 2022
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Aug 27, 2022
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 4, 2022
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
aglipska
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 7, 2022
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Dec 7, 2022
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jan 27, 2023
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 12, 2024
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
kosteev
pushed a commit
to kosteev/composer-airflow-test-copybara
that referenced
this pull request
Sep 12, 2024
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2024
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Nov 7, 2024
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 1, 2025
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
May 22, 2025
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Sep 17, 2025
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 15, 2025
apache/airflow#14686 fixes an issues with ES logging that should be released asap. Since we just released the providers it makes sense to release this separately. GitOrigin-RevId: 662cb8c6ac8becb26ff405f8b21acfccdd8de2ae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, Webserver fails with the following error. It happens because of
airflow/airflow/providers/elasticsearch/log/es_task_handler.py
Lines 165 to 168 in 99aab05
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.