Remove reinstalling azure-storage steps from CI / Breeze #14102
Conversation
|
Ah yeah due to the circumstances I failed to rebase and fixed my #13861 :). I will also push it to master of my fork to make sure it will work after merge as this touches sensitive CI scripts. |
|
Let's do it step-by step :) |
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
Since apache#12188 was merged I don't think we need this steps. This step also caused the docker build step for 2.0.1rc2 to fail
kaxil
force-pushed
the
remove-az-storage
branch
from
56b2aa6 to
13d534e
Compare
|
@potiuk Providers and Backports failed, is it because new version have not been released to Pypi yet? |
|
Nope. There are some import errors: https://github.com/apache/airflow/pull/14102/checks?check_run_id=1842014653#step:8:13099 so seems that some code still relies on the old azure storage . I will take a look shortly |
|
This is only problem for 1.10.14 (backport packages) and 2.0.0 (regular packages) build. The master build (where both master airflow and master provider packages work fine). The problem is coming from both airflow 2.0.0 and 1.10.14 having still the old
Unfortunately - in step 2 installing airflow 1.10.14 or 2.0.0 also installs Luckily this is easy to fix. I just run it in my master fork to be sure but it seems to work well :) : The fix is to install airflow 1.10.14 / airflow 2.0.0 WITHOUT any extras in step 2). This way we will keep dependencies installed in step 1) and no I make a PR to your PR shortly @kaxil - I will also move the depdencies to |
|
Hey @kaxil - this should fix the problem: astronomer#1247 |
Since #12188 was merged I don't think we need this steps. This step also caused the docker build step for 2.0.1rc2 to fail Co-authored-by: Jarek Potiuk <[email protected]> (cherry picked from commit 3ffd217)
Since #12188 was merged I don't think we need this steps. This step also caused the docker build step for 2.0.1rc2 to fail Co-authored-by: Jarek Potiuk <[email protected]> (cherry picked from commit 3ffd217)
Since #12188 was merged I don't think we need this steps. This step also caused the docker build step for 2.0.1rc2 to fail Co-authored-by: Jarek Potiuk <[email protected]> (cherry picked from commit 3ffd217)
Since apache#12188 was merged I don't think we need this steps. This step also caused the docker build step for 2.0.1rc2 to fail Co-authored-by: Jarek Potiuk <[email protected]> (cherry picked from commit 3ffd217)
2 participants
Since #12188 was merged I
don't think we need this steps.
This step also caused the docker build step for 2.0.1rc2 to fail.
I can confirm that after removing this steps -- I was able to push the 2.0.1rc2 image to dockerhub
https://hub.docker.com/r/apache/airflow/tags?page=1&ordering=last_updated&name=2.0.1rc2
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.