Remove azure-storage hack #13861
Closed
Remove azure-storage hack #13861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc: @ephraimbuddy |
After apache#12188 has been merged and constraints regenerated, we can now remove the hack where we had to reinstall azure-storage to override overlapping versions of azure-storage libraries. This paves the way to removing last dependency hacks we have in Airflow.
potiuk
force-pushed
the
remove-azure-storage-hack
branch
from
574d4c8 to
a506ce9
Compare
kaxil
reviewed
Jan 23, 2021
Comment on lines
+203
to
+204
| ARG AIRFLOW_BUILD_EPOCH="1" | ||
| ENV AIRFLOW_BUILD_EPOCH=${AIRFLOW_CI_BUILD_EPOCH} |
Member
There was a problem hiding this comment.
Shouldn't it be one of the following two:
Suggested change
| ARG AIRFLOW_BUILD_EPOCH="1" | |
| ENV AIRFLOW_BUILD_EPOCH=${AIRFLOW_CI_BUILD_EPOCH} | |
| ARG AIRFLOW_CI_BUILD_EPOCH="1" | |
| ENV AIRFLOW_CI_BUILD_EPOCH=${AIRFLOW_CI_BUILD_EPOCH} |
or
Suggested change
| ARG AIRFLOW_BUILD_EPOCH="1" | |
| ENV AIRFLOW_BUILD_EPOCH=${AIRFLOW_CI_BUILD_EPOCH} | |
| ARG AIRFLOW_BUILD_EPOCH="1" | |
| ENV AIRFLOW_BUILD_EPOCH=${AIRFLOW_BUILD_EPOCH} |
Member
There was a problem hiding this comment.
Technically it doesn't matter for cache burst but for consistency
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
Member
Author
|
Closing in favour of #14102 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #12188 has been merged and constraints regenerated, we can
now remove the hack where we had to reinstall azure-storage to
override overlapping versions of azure-storage libraries.
This paves the way to removing last dependency hacks we have in
Airflow.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.