-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Eager upgrade works also in editable mode. #13589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eager upgrade works also in editable mode. #13589
Conversation
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
0d799d5 to
822bc4a
Compare
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
9ca9871 to
c7d014a
Compare
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
c7d014a to
d09caf7
Compare
|
The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason. |
The recent change apache#13409 introduced common installation script but one case turned out to be not working. Installing Airflow in editable mode with eager upgrade fails on building production image (the CI image effectively did not have airflow installed in editable mode, which it should). This PR fixes that.
d09caf7 to
1f1a56e
Compare
|
Looks like the problem is fixed. Merging :) |
The recent change #13409 introduced common installation script but one case turned out to be not working. Installing Airflow in editable mode with eager upgrade fails on building production image (the CI image effectively did not have airflow installed in editable mode, which it should). This PR fixes that. (cherry picked from commit 543194d)
The recent change #13409 introduced common installation script
but one case turned out to be not working. Installing Airflow
in editable mode with eager upgrade fails on building production
image (the CI image effectively did not have airflow installed
in editable mode, which it should).
This PR fixes that.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.