Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jan 9, 2021

The recent change #13409 introduced common installation script
but one case turned out to be not working. Installing Airflow
in editable mode with eager upgrade fails on building production
image (the CI image effectively did not have airflow installed
in editable mode, which it should).

This PR fixes that.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions
Copy link

github-actions bot commented Jan 9, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jan 9, 2021
@potiuk potiuk force-pushed the fix-failing-master-on-prod-image-build branch from 0d799d5 to 822bc4a Compare January 9, 2021 17:30
@potiuk
Copy link
Member Author

potiuk commented Jan 9, 2021

@github-actions
Copy link

github-actions bot commented Jan 9, 2021

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

@potiuk potiuk force-pushed the fix-failing-master-on-prod-image-build branch 2 times, most recently from 9ca9871 to c7d014a Compare January 9, 2021 17:54
@github-actions
Copy link

github-actions bot commented Jan 9, 2021

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

@potiuk potiuk force-pushed the fix-failing-master-on-prod-image-build branch from c7d014a to d09caf7 Compare January 9, 2021 18:03
@github-actions
Copy link

github-actions bot commented Jan 9, 2021

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

The recent change apache#13409 introduced common installation script
but one case turned out to be not working. Installing Airflow
in editable mode with eager upgrade fails on building production
image (the CI image effectively did not have airflow installed
in editable mode, which it should).

This PR fixes that.
@potiuk potiuk force-pushed the fix-failing-master-on-prod-image-build branch from d09caf7 to 1f1a56e Compare January 9, 2021 18:32
@potiuk
Copy link
Member Author

potiuk commented Jan 9, 2021

Looks like the problem is fixed. Merging :)

@potiuk potiuk merged commit 543194d into apache:master Jan 9, 2021
@potiuk potiuk deleted the fix-failing-master-on-prod-image-build branch January 9, 2021 19:00
@potiuk potiuk added this to the Airflow 2.0.1 milestone Jan 10, 2021
kaxil pushed a commit that referenced this pull request Jan 21, 2021
The recent change #13409 introduced common installation script
but one case turned out to be not working. Installing Airflow
in editable mode with eager upgrade fails on building production
image (the CI image effectively did not have airflow installed
in editable mode, which it should).

This PR fixes that.

(cherry picked from commit 543194d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants