Fix webserver exiting when gunicorn master crashes #13518
Conversation
…pache#13469) A key consequence of this fix is that webserver will properly exit when gunicorn master dies and stops responding to signals.
ashb
changed the title
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
| self.num_workers_expected - num_workers_running, self.worker_refresh_batch_size | ||
| ) | ||
| self.log.debug( | ||
| self.log.info( |
There was a problem hiding this comment.
@kaxil
This action (spawning new workers) is taken specifically to correct an issue that was detected and logged at the error level few lines of code above. Given the prior error level log, it seemed reasonable to log an attempt at corrective action at the info level.
There was a problem hiding this comment.
That makes sense, can you create a new PR please to change the log level back to info. I revert that changed before merging the PR
There was a problem hiding this comment.
@kaxil Sure, I'll do it and I'll tag you on it.
|
Awesome work, congrats on your first merged pull request! |
3 participants
…#13469)
A key consequence of this fix is that webserver will properly
exit when gunicorn master dies and stops responding to signals.