Skip to content

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Dec 19, 2020

We use connexion to provider swagger UI.

appbuilder.add_link(
"REST API Reference (Swagger UI)", href='/api/v1./api/v1_swagger_ui_index', category="Docs"
)
appbuilder.add_link("REST API Reference (Redoc)", href="RedocView.redoc", category='Docs')

Part of: #12120


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Dockerfile.ci Outdated
Copy link
Member

@potiuk potiuk Dec 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it depends on #13177 so it should be updated accordingly (or maybe merge those two PRS).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged these PRs.

@mik-laj mik-laj changed the title Remove unused library - flask-swagger Remove unused libraries - flask-swagger, funcsigs Dec 19, 2020
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 19, 2020
@mik-laj mik-laj force-pushed the remove-flask-swagger branch from 420db0e to 430897d Compare December 20, 2020 01:25
@mik-laj mik-laj merged commit 49f104b into apache:master Dec 20, 2020
@mik-laj mik-laj deleted the remove-flask-swagger branch December 20, 2020 17:18
kaxil pushed a commit that referenced this pull request Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants