Update deprecation comments in setup.py#12903
Conversation
|
Added the 'pre-installed providers' we agreed to . Unfortunately @ashb it looks like we have to go back with install_requires to setup.py because depending on dev/prod environment (INSTALL_PROVIDERS_FROM_SOURCES) we have to dynmically add them to install_requires (unless of course we figure our something else). Seems like install_requires in setup.py overrides the one that is in setup.cfg unfortunately. |
a5127d2 to
71463c4
Compare
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
Let me have a look - see if there's anything we can do |
|
Is the only case we have to deal with when you do |
71463c4 to
143abf7
Compare
|
See #12916 for an approach that things in setup.cfg |
143abf7 to
08fa25e
Compare
potiuk
changed the title
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
Other than the pre-commit this LGTM.
Pre-emptively approving.
github-actions
Bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
ashb
changed the title
Updates comments in setup.py according to the latest 2.0 agreements about semver and clarifies use for arrays defined in setup.py. We will refactor those after 2.0 further, but for now we keep the current structure.
08fa25e to
e078e96
Compare
2 participants
Updates comments in setup.py according to the latest 2.0 agreements
about semver and clarifies use for arrays defined in setup.py.
We will refactor those after 2.0 further, but for now we keep
the current structure.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.