feat: PodGenerator.construct_pod uses k8s args instead of command
#12762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:CLI
provider:cncf-kubernetes
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
pbastia
force-pushed
the
fix/k8s_worker_pod_uses_container_entrypoint
branch
from
1155664 to
d9e8bbf
Compare
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
pbastia
force-pushed
the
fix/k8s_worker_pod_uses_container_entrypoint
branch
from
14f3428 to
269ba8b
Compare
pbastia
force-pushed
the
fix/k8s_worker_pod_uses_container_entrypoint
branch
from
269ba8b to
95e15dc
Compare
potiuk
added a commit
to PolideaInternal/airflow
that referenced
this pull request
Dec 7, 2020
The change is backwards-compatible. It still allows to pass airflow command without "airflow" as first parameter, but you can now also pass "airflow" and the rest of the parameters will be treated as "airflow" command parameters. Documentation is updated to reflect the entrypoint behaviour including _CMD option in SQL connections. Part of apache#12762 and apache#12602 Partially extracted from apache#12766
potiuk
added a commit
that referenced
this pull request
Dec 7, 2020
The change is backwards-compatible. It still allows to pass airflow command without "airflow" as first parameter, but you can now also pass "airflow" and the rest of the parameters will be treated as "airflow" command parameters. Documentation is updated to reflect the entrypoint behaviour including _CMD option in SQL connections. Part of #12762 and #12602 Partially extracted from #12766
potiuk
added a commit
that referenced
this pull request
Dec 13, 2020
The change is backwards-compatible. It still allows to pass airflow command without "airflow" as first parameter, but you can now also pass "airflow" and the rest of the parameters will be treated as "airflow" command parameters. Documentation is updated to reflect the entrypoint behaviour including _CMD option in SQL connections. Part of #12762 and #12602 Partially extracted from #12766 (cherry picked from commit 4d44faa)
kaxil
pushed a commit
that referenced
this pull request
Jan 21, 2021
The change is backwards-compatible. It still allows to pass airflow command without "airflow" as first parameter, but you can now also pass "airflow" and the rest of the parameters will be treated as "airflow" command parameters. Documentation is updated to reflect the entrypoint behaviour including _CMD option in SQL connections. Part of #12762 and #12602 Partially extracted from #12766 (cherry picked from commit 4d44faa)
kaxil
pushed a commit
that referenced
this pull request
Jan 22, 2021
The change is backwards-compatible. It still allows to pass airflow command without "airflow" as first parameter, but you can now also pass "airflow" and the rest of the parameters will be treated as "airflow" command parameters. Documentation is updated to reflect the entrypoint behaviour including _CMD option in SQL connections. Part of #12762 and #12602 Partially extracted from #12766 (cherry picked from commit 4d44faa)
dimberman
approved these changes
Feb 4, 2021
Contributor
|
Hi @pbastia, can you please rebase this PR? I can merge once that is done :) |
|
@dimberman didn't this get fixed in #12766 ? |
Contributor
|
@matthieu-foucault Doh! Thanks for catching that. Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #12602
Refactors the
PodGenerator.construct_pod(..)method to create kubernetes pods withargsinstead ofcommand.This allows the container's entrypoint to run, then call airflow with the proper arguments, instead of bypassing it altogether.