Skip to content

Conversation

@dimberman
Copy link
Contributor

Creates a rule to ensure users have a 2.0 compatible hostname_callable
configuration in their airflow.cfg

addresses #11044


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Creates a rule to ensure users have a 2.0 compatible hostname_callable
configuration in their airflow.cfg

addresses #11044
@dimberman dimberman linked an issue Dec 1, 2020 that may be closed by this pull request
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, oh yeah.

I get your point now @dimberman. (sorry)

If a user is on 1.10.13/1.10.14 and follows this advice, the config option would stop working!

Given we have a backwards compat in 2.0 for the old setting, we maybe don't need this.

Or we sneak in a forward-compat in to 1.10.14 -- it's not a big change. (I think this is my preferred)

@github-actions
Copy link

github-actions bot commented Dec 1, 2020

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 1, 2020
@kaxil
Copy link
Member

kaxil commented Dec 2, 2020

@dimberman :

E       AssertionError: 'Erro[92 chars]ge to `dummyhostname.function`' != 'Erro[92 chars]ge to `dummyhostname.function`.This will be deprecated in 2.0.'
E       - Error: hostname_callable `dummyhostname:function` contains a colon instead of a dot. please change to `dummyhostname.function`
E       + Error: hostname_callable `dummyhostname:function` contains a colon instead of a dot. please change to `dummyhostname.function`.This will be deprecated in 2.0.
E       ?                                                                                                                               ++++++++++++++++++++++++++++++++

tests/upgrade/rules/test_hostname_callable_rule.py:29: AssertionError

@github-actions
Copy link

github-actions bot commented Dec 2, 2020

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@kaxil kaxil merged commit 326e0f9 into v1-10-stable Dec 3, 2020
@kaxil kaxil deleted the hostname-callable-rule branch December 3, 2020 00:08
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
)

Creates a rule to ensure users have a 2.0 compatible hostname_callable
configuration in their airflow.cfg

closes apache#11044

Co-authored-by: Ash Berlin-Taylor <[email protected]>
Co-authored-by: Kaxil Naik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create HostnameCallableRule to ease upgrade to Airflow 2.0

4 participants