-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Create HostnameCallableRule to ease upgrade to Airflow 2.0 #12743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Creates a rule to ensure users have a 2.0 compatible hostname_callable configuration in their airflow.cfg addresses #11044
ashb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, oh yeah.
I get your point now @dimberman. (sorry)
If a user is on 1.10.13/1.10.14 and follows this advice, the config option would stop working!
Given we have a backwards compat in 2.0 for the old setting, we maybe don't need this.
Or we sneak in a forward-compat in to 1.10.14 -- it's not a big change. (I think this is my preferred)
Co-authored-by: Ash Berlin-Taylor <[email protected]>
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
|
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
…to hostname-callable-rule
) Creates a rule to ensure users have a 2.0 compatible hostname_callable configuration in their airflow.cfg closes apache#11044 Co-authored-by: Ash Berlin-Taylor <[email protected]> Co-authored-by: Kaxil Naik <[email protected]>
Creates a rule to ensure users have a 2.0 compatible hostname_callable
configuration in their airflow.cfg
addresses #11044
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.