Improve verification of images with PIP check #12718
Conversation
|
Still draft, buit it should make it easy to handle dep changes in the future |
potiuk
force-pushed
the
better-pip-check-validation
branch
3 times, most recently
from
8551dae to
7d912bc
Compare
potiuk
added
the
full tests needed
potiuk
force-pushed
the
better-pip-check-validation
branch
from
7d912bc to
5630308
Compare
|
It's ready for review. I thnk it's really nice change that allows to focus on dep changes and explains how to fix it in case it happens.. |
potiuk
force-pushed
the
better-pip-check-validation
branch
from
5630308 to
c903d9d
Compare
|
@turbaszek @kaxil @ashb @mik-laj [@mjpieters ?] -> The PR with improved PIP check is ready - and you can actually see how things will work when there is a problem with PIP check (we still have the azure problem to fix in the prod image that @ephraimbuddy is working on): I already have a couple of small improvements to add:
However, I would love to get some comments on the wording and instructions. I based it on my experiences with getting rid of the conflicts and how I was solving them. I think those instructions should be clear enough for the contributors and commiters on what they should do in case their change actually results in conflict so I am happy to hear any comments. |
|
BTW. once I merge this change I will also add an automated "update to newer dependencies" behaviour whenever setup.py changes in the PR. With PIP check guarding it, we should be safe to do |
potiuk
force-pushed
the
better-pip-check-validation
branch
from
c903d9d to
0c7c9b8
Compare
|
This is what you get now when there is a pip check error:
|
Verification of images with PIP is done in separate jobs and they provide useful information to committers and contributors when the pip check fails.
potiuk
force-pushed
the
better-pip-check-validation
branch
from
0c7c9b8 to
80fc9dc
Compare
Verification of images with PIP is done in separate jobs and they provide useful information to committers and contributors when the pip check fails. (cherry picked from commit ebc8fcf)
Verification of images with PIP is done in separate jobs and they provide useful information to committers and contributors when the pip check fails. (cherry picked from commit ebc8fcf)
Verification of images with PIP is done in separate jobs and they provide useful information to committers and contributors when the pip check fails. (cherry picked from commit ebc8fcf)
Verification of images with PIP is done in separate jobs and they provide useful information to committers and contributors when the pip check fails. (cherry picked from commit ebc8fcf)
2 participants
Verification of images with PIP is done in separate jobs and
they provide useful information to committers and contributors
when the pip check fails.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.