Skip to content

Conversation

@ephraimbuddy
Copy link
Contributor

@ephraimbuddy ephraimbuddy commented Nov 27, 2020

This PR adds example dag and system tests for azure wasb and fileshare.

It will help us validate the upgrade for azure wasb and fileshare in #12188

cc: @potiuk @mik-laj
Please, I'm not sure where to put the system test for fileshare, I added it to hooks tests. Let me know if I should change the location

To test this, create a json file named wasb_key.json in /files/airflow-breeze-config/keys. Fill it with connection fields: e.g

{"login":"account_name", "password": "account_key"}


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the provider:microsoft-azure Azure-related issues label Nov 27, 2020
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

@potiuk potiuk merged commit 543d88b into apache:master Nov 28, 2020
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Nov 28, 2020
@github-actions
Copy link

The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!

@ephraimbuddy ephraimbuddy deleted the wasb-system branch November 28, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge provider:microsoft-azure Azure-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants