Add BaseOperatorMetaclassRule #12629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an upgrade check rule that ensures that users are not using custom metaclasses in their custom operators
ashb
reviewed
Nov 25, 2020
ashb
reviewed
Nov 25, 2020
Co-authored-by: Ash Berlin-Taylor <[email protected]>
Co-authored-by: Ash Berlin-Taylor <[email protected]>
turbaszek
reviewed
Nov 26, 2020
|
|
||
|
|
||
| def check_task_for_metaclasses(task): | ||
| class_type = type(task.__class__) |
turbaszek
approved these changes
Nov 26, 2020
Member
turbaszek
left a comment
turbaszek
left a comment
There was a problem hiding this comment.
LGTM! Tested this locally 👌
|
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it! |
github-actions
bot
added
the
full tests needed
ashb
reviewed
Nov 27, 2020
kaxil
approved these changes
Nov 27, 2020
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
Adds an upgrade check rule that ensures that users are not using custom metaclasses in their custom operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an upgrade check rule that ensures that users are not using custom
metaclasses in their custom operators
Fixes #11038
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.