Fix Connection.description migration for MySQL8 #12614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to not executing MySQL8 tests Fixed in apache#12591 added description for connection table was not compatible with MySQL8 with utf8mb4 character set. This change adds migration and fixes the previous migration to make it compatible.
potiuk
force-pushed
the
fix-mysql-client-8-5.7-compatible-encoding
branch
from
c37b0f7 to
8d8e595
Compare
We missed that when we added support for differnet mysql versions in apache#7717 when we removed default character set setting for the database server. This change forces the default on database server to be utf8mb4 - regardless if MySQL 5.7 or MySQL8 is used. Utf8mb4 is default for MySQL8 but latin1 is default fo MySQL 5.7. There was a suspected root cause of the problem: https://dev.mysql.com/doc/refman/8.0/en/charset-connection.html where mysql client falls back to the default collation if the client8 is used with 5.7 database, but this should be no problem if the default DB character set is forced to be utf8mb4 This PR restores forcing the server-side encoding.
potiuk
force-pushed
the
fix-mysql-client-8-5.7-compatible-encoding
branch
from
8d8e595 to
c8dbff4
Compare
ashb
approved these changes
Nov 25, 2020
github-actions
bot
added
the
full tests needed
|
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it! |
Member
Author
|
Initialization and most tests work. Merging. |
potiuk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #12596 so only the last commit counts.
We missed that when we added support
for differnet mysql versions in #7717 when we removed default
character set setting for the database server.
This change forces the default on database server to be
utf8mb4 - regardless if MySQL 5.7 or MySQL8 is used.
Utf8mb4 is default for MySQL8 but latin1 is default fo MySQL 5.7.
There was a suspected root cause of the problem:
https://dev.mysql.com/doc/refman/8.0/en/charset-connection.html
where mysql client falls back to the default collation if
the client8 is used with 5.7 database, but this should be
no problem if the default DB character set is forced to be
utf8mb4
This PR restores forcing the server-side encoding.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.