Webserver: Further Sanitize values passed to origin param #12459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimberman
approved these changes
Nov 18, 2020
|
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed! |
github-actions
bot
added
the
okay to merge
ashb
reviewed
Nov 18, 2020
ashb
reviewed
Nov 18, 2020
ashb
requested changes
Nov 18, 2020
github-actions
bot
removed
the
okay to merge
ashb
approved these changes
Nov 18, 2020
|
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed! |
github-actions
bot
added
the
okay to merge
kaxil
added a commit
that referenced
this pull request
Nov 18, 2020
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Nov 24, 2020
Follow-up of apache#10334 (cherry picked from commit 9818932)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Nov 24, 2020
Follow-up of apache#10334 (cherry picked from commit 9818932) (cherry picked from commit 4c27334) (cherry picked from commit 1b80527d279e405312d16e51d37db1aaa95ced94)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Nov 27, 2020
Follow-up of apache#10334 (cherry picked from commit 9818932)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Dec 1, 2020
Follow-up of apache#10334 (cherry picked from commit 9818932) (cherry picked from commit 4c27334)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Mar 12, 2021
Follow-up of apache#12459 & apache#10334 Since https://github.com/python/cpython/pull/24297/files (bpo-42967) also removed ';' as query argument separator, we remove query arguments with semicolons.
kaxil
added a commit
that referenced
this pull request
Mar 12, 2021
Follow-up of #12459 & #10334 Since https://github.com/python/cpython/pull/24297/files (bpo-42967) also removed ';' as query argument separator, we remove query arguments with semicolons.
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Mar 16, 2021
Follow-up of apache#12459 & apache#10334 Since https://github.com/python/cpython/pull/24297/files (bpo-42967) also removed ';' as query argument separator, we remove query arguments with semicolons. (cherry picked from commit 409c249)
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Mar 16, 2021
Follow-up of apache#12459 & apache#10334 Since https://github.com/python/cpython/pull/24297/files (bpo-42967) also removed ';' as query argument separator, we remove query arguments with semicolons. (cherry picked from commit 409c249) (cherry picked from commit 5a42706)
ashb
pushed a commit
that referenced
this pull request
Mar 19, 2021
Follow-up of #12459 & #10334 Since https://github.com/python/cpython/pull/24297/files (bpo-42967) also removed ';' as query argument separator, we remove query arguments with semicolons. (cherry picked from commit 409c249)
kaxil
added a commit
that referenced
this pull request
Mar 19, 2021
Follow-up of #12459 & #10334 Since https://github.com/python/cpython/pull/24297/files (bpo-42967) also removed ';' as query argument separator, we remove query arguments with semicolons. (cherry picked from commit 409c249)
ashb
pushed a commit
that referenced
this pull request
Apr 15, 2021
Follow-up of #12459 & #10334 Since https://github.com/python/cpython/pull/24297/files (bpo-42967) also removed ';' as query argument separator, we remove query arguments with semicolons. (cherry picked from commit 409c249)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #10334
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.