Skip to content

Conversation

@ashb
Copy link
Member

@ashb ashb commented Nov 6, 2020

Switch out deprecated helm repo for new stable repo.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@ashb ashb requested review from dimberman, kaxil and potiuk November 6, 2020 15:10
@github-actions
Copy link

github-actions bot commented Nov 6, 2020

The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it!

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Nov 6, 2020
@ashb
Copy link
Member Author

ashb commented Nov 6, 2020

Will merge as soon as the first test that uses helm passes. (We've used this on our own non-Airflow projects so it should be good)

@ashb
Copy link
Member Author

ashb commented Nov 6, 2020

Kube tests failed, and but I think that was a transient error. Merging anyway as it is much better if not perfect.

@ashb ashb merged commit 128c991 into apache:master Nov 6, 2020
@ashb ashb deleted the fix-helm-chart-deprecation branch November 6, 2020 16:05
@potiuk
Copy link
Member

potiuk commented Nov 6, 2020

I think we have a "real" problem introduced a day ago or so. I am taking a look at this . This seems to be fully repeatable.

@mjpieters
Copy link
Contributor

I still see this on my 1-10-stable pull requests: https://github.com/apache/airflow/runs/1395402772?check_suite_focus=true#step:6:3841

Looks like this needs backporting.

@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 13, 2020
potiuk added a commit to PolideaInternal/airflow that referenced this pull request Nov 13, 2020
@potiuk potiuk added the type:improvement Changelog: Improvements label Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:helm-chart Airflow Helm Chart full tests needed We need to run full set of tests for this PR to merge type:improvement Changelog: Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants