Skip to content

Conversation

@ryanahamilton
Copy link
Contributor

Follow-up to the auto-refresh feature just added in #11534. This defaults the auto-refresh switch to an "off" state if the DAG does not have RUNNING DAG runs.

image


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Oct 15, 2020
edges=edges,
show_external_log_redirect=task_log_reader.supports_external_link,
external_log_name=external_log_name)
external_log_name=external_log_name,
Copy link
Member

@kaxil kaxil Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mostly thinking of the current DagRun i.e. if this DagRun isn't running we don't refresh as with the current change, if another DagRun is running, this will still refresh automatically

You can get the state of it already using dt_nr_dr_data['dr_state'] (also used on L1839)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks @kaxil!

@kaxil kaxil merged commit 89d4dd8 into apache:master Oct 15, 2020
@kaxil kaxil deleted the auto_refresh_default branch October 15, 2020 22:36
@potiuk potiuk mentioned this pull request Oct 16, 2020
@ryanahamilton ryanahamilton added the area:UI Related to UI/UX. For Frontend Developers. label Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants