Remove flask-admin based Plugins #11515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`admin_views` & `menu_links` were used for non-rbac UI.For FAB we use `flask_appbuilder_views` & `flask_appbuilder_menu_links`
mik-laj
reviewed
Oct 14, 2020
| 'blueprint': bp | ||
| } for bp in plugin.flask_blueprints]) | ||
|
|
||
| if (admin_views and not flask_appbuilder_views) or (menu_links and not flask_appbuilder_menu_links): |
Member
There was a problem hiding this comment.
if (plugin.admin_views and not plugin.appbuilder_views) or (plugin.menu_links and not plugin.flask_appbuilder_menu_links):
In my opinion, this message may remain, but it seems to me that the global variable can be deleted completely. Users who migrate to RBAC proposed by airflow upgrade-check may not be aware of the consequences.
Member
Author
mik-laj
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
admin_views&menu_linkswere used for non-rbac UI.For FAB we useflask_appbuilder_views&flask_appbuilder_menu_links^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.