Skip to content

Resolve MSSQL DAG serialization bug by changing datatype for execution date #11512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ashb merged 13 commits into from
Oct 15, 2020
Merged

Resolve MSSQL DAG serialization bug by changing datatype for execution date #11512

ashb merged 13 commits into from
Oct 15, 2020

Conversation

@Kaash
Copy link
Contributor

@Kaash Kaash commented Oct 13, 2020

Submitting a PR to resolve the below reported issue when enabling serialization with MSSQ:: #11493

@boring-cyborg
Copy link

boring-cyborg bot commented Oct 13, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@Kaash Kaash mentioned this pull request Oct 13, 2020
Closed
@mik-laj
Copy link
Member

mik-laj commented Oct 13, 2020 •
edited
Loading

@alexmc-ms @aneesh-joseph @jmfreeman @mattinbits @jatskin Can you look at it? I don't have experience with MSSQL.

@github-actions
Copy link

github-actions bot commented Oct 13, 2020

The Workflow run is cancelling this PR. Building image for the PR has been cancelled

@potiuk
Copy link
Member

potiuk commented Oct 13, 2020

Hey @Kaash . Can you please rebase this one to latest master. We fixed (hopefully) a problem with queues of jobs for GitHub actions and I think when you rebase, it shoudl run much faster (more info on devlist shortly).

@ashb ashb added area:MetaDB Meta Database related issues. area:serialization labels Oct 14, 2020
ashb
ashb reviewed Oct 14, 2020
View reviewed changes
airflow/migrations/versions/52d53670a240_fix_mssql_exec_date_rendered_task_instance.py Outdated
Copy link
Member

@ashb ashb Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really have to drop the whole table, instead of just changing the column type?

Can you link (here, not in code) the difference between DATETIME2 and what ever sa.TIMESTAMP gives?

Copy link
Contributor Author

@Kaash Kaash Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot alter column 'execution_date' because it is 'timestamp'. We're basically stuck with what we have. Bear in mind that the way this is at the moment (sa.TIMESTAMP) doesn't work with MSSQL

Copy link
Contributor Author

@Kaash Kaash Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I should add that this is because SQL Server doesn't allow it. Below is the official explanation from Microsoft documentation - hope this helps.

https://docs.microsoft.com/en-us/sql/t-sql/statements/alter-table-transact-sql?view=sql-server-ver15:

_****ALTER COLUMN
Specifies that the named column is to be changed or altered.

The modified column can't be:

A column with a timestamp data type.****_

Copy link
Member

@ashb ashb Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wat.

Cool, thanks

@github-actions
Copy link

github-actions bot commented Oct 14, 2020

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.

@ashb ashb merged commit 03a632e into apache:master Oct 15, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 15, 2020

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ashb ashb ashb approved these changes

Assignees

No one assigned

Labels

area:MetaDB Meta Database related issues. area:serialization

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Kaash @mik-laj @potiuk @ashb